fix: webkit quicklinks copy for webkit #9832
Merged
+67
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschmidt
reviewed
Oct 19, 2023
| new ClipboardItem({ | ||
| 'text/plain': createQuicklink(args).then( | ||
| (link) => new Blob([link.url], { type: 'text/plain' }) | ||
| ) |
There was a problem hiding this comment.
Does this really accept a promise? seems weird
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/API/ClipboardItem/ClipboardItem
An Object with the MIME type as the key and data as the value. The data can be represented as a Blob, a String or a Promise which resolves to either a blob or string.
Co-authored-by: Dominik Schmidt <[email protected]>
|
SonarCloud Quality Gate failed.
|
dschmidt
approved these changes
Oct 19, 2023
ownclouders
pushed a commit
that referenced
this pull request
Oct 19, 2023
* fix: webkit quicklinks copy for webkit * Update packages/web-pkg/src/helpers/share/link.ts Co-authored-by: Dominik Schmidt <[email protected]> --------- Co-authored-by: Dominik Schmidt <[email protected]>
LukasHirt
pushed a commit
to LukasHirt/web
that referenced
this pull request
Oct 25, 2023
* fix: webkit quicklinks copy for webkit * Update packages/web-pkg/src/helpers/share/link.ts Co-authored-by: Dominik Schmidt <[email protected]> --------- Co-authored-by: Dominik Schmidt <[email protected]>
5 tasks
12 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* fix: webkit quicklinks copy for webkit * Update packages/web-pkg/src/helpers/share/link.ts Co-authored-by: Dominik Schmidt <[email protected]> --------- Co-authored-by: Dominik Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
copying quicklings was broken on webkit based browsers, this is fixed now.
Related Issue
Motivation and Context
... hmmmm, no bugs, happy dev 🤣
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: